Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 5345 #5361

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Fix issue 5345 #5361

merged 3 commits into from
Apr 17, 2018

Conversation

derekdreery
Copy link
Contributor

@derekdreery derekdreery commented Apr 15, 2018 •
edited
Loading

Fixes #5345.

Also adds some docs and Debug impls.

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@derekdreery derekdreery force-pushed the issue_5345 branch 2 times, most recently from f8a8a8e to 0b5a291 Compare April 16, 2018 10:07
@derekdreery
Copy link
Contributor Author

derekdreery commented Apr 17, 2018 •
edited
Loading

I know what the problem is!

core/compiler/context/unit_dependencies.rs:L217: filter(|d| d.name() == dep.name()): it filters on name, so it captures both packages.
core/compiler/context/unit_dependencies.rs:L218: any(|dep| match dep.kind() {: the correct package matches, and because this is any it matches for both packages.

@derekdreery derekdreery changed the title [Wip] fix issue 5345 Fix issue 5345 Apr 17, 2018
@derekdreery
Copy link
Contributor Author

Ready for review.

@matklad
Copy link
Member

matklad commented Apr 17, 2018

Excellent, thanks @derekdreery !

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 17, 2018

📌 Commit d70f91e has been approved by matklad

@bors
Copy link
Collaborator

bors commented Apr 17, 2018

⌛ Testing commit d70f91e with merge 30bf81b...

bors added a commit that referenced this pull request Apr 17, 2018
@bors
Auto merge of #5361 - derekdreery:issue_5345, r=matklad
30bf81b 
Fix issue 5345

Fixes #5345.

Also adds some docs and Debug impls.
@bors
Copy link
Collaborator

bors commented Apr 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 30bf81b to master...

@bors bors merged commit d70f91e into rust-lang:master Apr 17, 2018
@derekdreery
Copy link
Contributor Author

😃

@derekdreery derekdreery deleted the issue_5345 branch April 17, 2018 15:12
@derekdreery derekdreery mentioned this pull request Apr 17, 2018
Closed
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matklad matklad

Labels
None yet
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

pretty-env-logger = 0.2 fails to cargo doc
5 participants
@derekdreery @rust-highfive @matklad @bors @ehuss